[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181772422 That said, just for a comparison purpose, spark has its own model export and import feature, along with pmml export. Hoping to fully support pmml import in a

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181790876 I agree with @sachingoel0101 on the import complexity but, from our point of view, Flink is the perfect platform to evaluate models in streaming and we are using it

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181771679 As the original author of this PR, I'd say this: I tried implementing the import features but they aren't worth it. You have to discard most of the valid

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181799783 @sachingoel0101 I agree. Nonetheless, an easy way to store and move a model generated in batch to a streaming enviroment would be a really useful feature and we go back

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181798643 That is a good point. In streaming setting, it does indeed make sense for the model to be available. However, in my opinion, then it would make sense to actually

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181803637 I'm all for that. Flink's models should be transferable at least across flink. But that should be part of a separate PR, and not block this one as it has been

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181757426 Well that wouldn't be a problem for the export: you will create and therefore export only models that have `double` as datatype for parameters but that's not an issue.

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-08 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181442715 Hello, any news on this PR? @smarthi PMML is actually an industry standard and widely used to support model portability in complex infrastructures.

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-08 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181739512 Hi @chobeat, thanks for leaving your comments. About compatibility with other system (such as R or MLlib), I meant that we cannot achieve compatibility with

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-08 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181509602 Hi @chobeat, thanks for pinging this issue. I forgot sending a discuss email to mailing thread. I think we have to discuss about followings: * What is main

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-08 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181578375 Hi @chiwanpark, > What is main purpose to support PMML? Is this feature for only model portability in FlinkML? I've used PMML extensively in a previous

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-29 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-152265442 Suggest that you see how PMML been's done on Oryx 2.0 (PMML in Spark followed Oryx 2.0). PMML support was discussed various times on the Mahout project and was never

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-08 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1186#discussion_r41496701 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/SVM.scala --- @@ -18,23 +18,20 @@ package

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-08 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1186#discussion_r41497880 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -124,6 +121,52 @@ class

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-08 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1186#discussion_r41497844 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -18,15 +18,12 @@ package

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-08 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-146501909 The PMML model is quite extensive, and there isn't enough support in the ML library for utilizing most of the things [like FieldUsageType, DataTypes etc.]. I had

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-08 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1186#discussion_r41498327 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -124,6 +121,52 @@ class

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-08 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1186#discussion_r41497773 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -124,6 +121,52 @@ class

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-10-08 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-146570848 Okay, We need some discussion in mailing list about ML model import/export feature. I think that PMML support is one of sub-issues related to the ML model

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2015-09-28 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1186 [FLINK-1966][ml]Add support for Predictive Model Markup Language 1. Adds an interface to allow exporting of models to PMML format. 2. Implements export methods for the existing SVM and