Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1985
Hi @skavulya, I just quickly reviewed your updated PR and left few
comments. They are not critical things but It would be better to fix them.
Other things are very good.
---
If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291933
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/optimization/RegularizationPenaltyTest.scala
---
@@ -0,0 +1,65 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291911
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/optimization/LossFunctionTest.scala
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291552
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationPenalty.scala
---
@@ -0,0 +1,215 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291461
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PartialLossFunction.scala
---
@@ -47,21 +47,106 @@ object SquaredLoss
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291353
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PartialLossFunction.scala
---
@@ -47,21 +47,106 @@ object SquaredLoss
Github user skavulya commented on the pull request:
https://github.com/apache/flink/pull/1985
@tillrohrmann @thvasilo I made the changes you recommended. Please let me
know if they look ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear