Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/686#issuecomment-103463683
Pull request updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/686#discussion_r30592879
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -914,7 +917,15 @@ public JavaPlan createProgramPlan(String jobName)
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/686#issuecomment-103470201
Looks good, modulo the commas.
+1 to merge after fixing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/686#issuecomment-103053538
That makes sense. Can we rename the flag to `wasExecuted` or so?
How about a slight modification of the error message:
No new data sinks have been
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/686#issuecomment-103117477
- Yes, we can rename the variable to `wasExecuted`.
- I already added `print()` to the message because I anticipated it to
become eager :)
- I like your error
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/686
[FLINK-2026] add a flag to indicate previous executions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink count-collect-execute
