Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/704#issuecomment-104552796
Oh that's true,yes. LGTM then!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/704
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/704#issuecomment-104546413
That's happening because the `Estimator`, `Transformer` and `Predictor`
have a default value for the ParameterMap parameter.
---
If your project is set up for it,
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/704#issuecomment-104546529
If there are no further objections, then I'll merge this PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/704#discussion_r30783065
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -22,38 +22,47 @@ import breeze.linalg
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/704#discussion_r30783847
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -22,38 +22,47 @@ import breeze.linalg
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/704#issuecomment-104186229
Documentation :white_check_mark:
Scaladocs :white_check_mark:
Tests :white_check_mark:
No code outside of flink-ml touched :white_check_mark:
:ship:
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/704#issuecomment-104248691
LGTM as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/704
[FLINK-2050] Introduces new pipelining mechanism for FlinkML
This PR introduces the new pipelining mechanism for FlinkML. In order to
make pipeline applicable to different input types, the
