Github user uce commented on the pull request:
https://github.com/apache/flink/pull/754#issuecomment-141400026
I'm afraid that the requirements might change. Without the scheduling
changes, this will be dead code. I would like to revisit this when there is
someone to work on the sched
Github user uce closed the pull request at:
https://github.com/apache/flink/pull/754
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/754#issuecomment-138910462
Why not add it now and have one more step done towards batch scheduling?
Wouldn't it be duplicate work if this PR is put aside now and the internals
change?
B
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/754#issuecomment-138907431
It's done on my side. The question is whether it makes sense to merge this
w/o any plans to continue on the batch scheduling. My personal answer is no. I
would close this and
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/754#issuecomment-138890100
@uce, what's the status of this PR? Has @tillrohrmann's PR that you are
referring to been merged?
---
If your project is set up for it, you can reply to this email and h
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/754#issuecomment-114176855
Addressed @tillrohrmann's comments and rebased on master. @tillrohrmann,
should we merge with your upcoming changes or can we merge it before?
---
If your project is set up
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31743017
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/BatchSchedulingTest.java
---
@@ -0,0 +1,521 @@
+/*
+ * Licens
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31729748
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/BatchSchedulingTest.java
---
@@ -0,0 +1,521 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31728385
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/BatchSchedulingTest.java
---
@@ -0,0 +1,521 @@
+/*
+ * Licens
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31728131
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -588,23 +590,74 @@ void markFinished() {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31716687
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/BatchSchedulingTest.java
---
@@ -0,0 +1,521 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31716498
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/BatchSchedulingTest.java
---
@@ -0,0 +1,521 @@
+/*
+ * Licens
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31715030
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -588,23 +590,74 @@ void markFinished() {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/754#discussion_r31714986
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -588,23 +590,74 @@ void markFinished() {
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/754#issuecomment-108847772
I'm not sure if this is what you mean: the triggering is happening on the
level of the intermediate result and not the execution. The code just happens
to be in the execution
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/754#issuecomment-108843486
The hook that starts the next batch source is at the level of the
`Execution`. That means that as soon as one execution is finished, the next leg
would start.
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/754
[FLINK-2119] Add ExecutionGraph support for batch scheduling
This PR adds support for a newly introduced scheduling mode
`BATCH_FROM_SOURCES`. The goal for me was to make this change *minimally
invasive
17 matches
Mail list logo
