Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/805
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-137104511
Sorry, it fell behind in the long list of Pull Requests.
I'll check it and will merge it if Travis gives a green light.
---
If your project is set up for it, you
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-136689479
Could someone please check this, it has been here for a while and I've got
some other stuff building on top of this!
---
If your project is set up for it, you can reply t
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-125179652
The IT case now looks for a jar inside the ml-folder which does not contain
"test" or "original".
Thus the IT case should work for different flink-versions as long as t
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-115180597
This did not work unfortunately, the class was available in the test, but
unfortunately not in the shell which is invoked in the test.
However, if you add the classpat
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-114046659
To add more jars to the Classpath, you can write the test in the following
way: The test itself is just a wrapper that instantiates a custom classloader
with your ext
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-112477088
Changed according to comments,
@tillrohrmann I did not check it on a cluster, since I don't have one
available at the moment. I checked with a local jobmanager (using
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32508286
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -44,6 +46,16 @@ object FlinkShell {
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32508271
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkILoop.scala
---
@@ -191,5 +203,14 @@ HINT: You can use print() on a Da
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32508276
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -30,7 +31,8 @@ object FlinkShell {
/
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-112053328
Looks good @nikste. I only had some minor comments.
Did you test the code on a cluster? Can we maybe add a test case which
tests that external jars are shipp
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32415111
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -51,14 +63,16 @@ object FlinkShell {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32415084
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -44,6 +46,16 @@ object FlinkShell {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32414932
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -30,7 +31,8 @@ object FlinkShell {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32414909
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkILoop.scala
---
@@ -191,5 +203,14 @@ HINT: You can use print() o
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-112041788
This should work now. It sends the jar alongside the compiled user-code to
the cluster.
---
If your project is set up for it, you can reply to this email and have your
re
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-110064581
You are right. I only tried it with the local execution environment. It
does not work if you start a separate job manager on your machine.
---
If your project is set up
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-110001500
I think this is only half of what is needed. The other half would be
sending the jar files along when submitting the job with the modified
RemoteEnvironment.
---
If yo
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/805
[FLINK-2161] modified Scala shell start script to take additional argument
(-cp or --classpathâ¦
â¦) for external libraries
You can merge this pull request into a Git repository by running:
$
19 matches
Mail list logo
