[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/835#issuecomment-114790171 Can you take care of this @mbalassi ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-22 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/835#issuecomment-114149626 I do not think that we can expect that every user starts from the quickstart poms, but it is true that a reference to that would have been nicer. I have to admi

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/835#issuecomment-114143834 I am a bit confused here. With the quickstart maven projects, fat jar building works without configuring, as it defines proper assembly and share configurations for f

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/835 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/835#issuecomment-112072013 Thanks for the comments, I have addressed them. If no other objections I would like to merge this in the evening. --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32404022 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403929 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403908 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403849 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the cla

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403843 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the cla

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403522 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403433 --- Diff: docs/libs/ml/index.md --- @@ -69,6 +69,8 @@ Next, you have to add the FlinkML dependency to the `pom.xml` of your project. {% endhigh

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403415 --- Diff: docs/libs/gelly_guide.md --- @@ -43,6 +43,8 @@ Add the following dependency to your `pom.xml` to use Gelly. ~~~ +Note that

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32403242 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/835#discussion_r32392995 --- Diff: docs/apis/cluster_execution.md --- @@ -80,67 +80,73 @@ Note that the program contains custom user code and hence requires a JAR file wi the cla

[GitHub] flink pull request: [FLINK-2209] Document linking with jars not in...

2015-06-14 Thread mbalassi
GitHub user mbalassi opened a pull request: https://github.com/apache/flink/pull/835 [FLINK-2209] Document linking with jars not in the binary dist You can merge this pull request into a Git repository by running: $ git pull https://github.com/mbalassi/flink flink-2209 Altern