[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123648113 This only occurs with your changes, right? Then let's first fix the issue of the failing tests before merging. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123645039 +1 for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123646720 You are right. I just updated it. What about the failing YARN test. Is there already a JIRA for it? https://travis-ci.org/apache/flink/builds/72019686 --- If your

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123674841 I don't know exactly. My changes should not influence YARN component (as fas as I can tell). YARN test have been instable a lot -- I would guess, it is a general issue.

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123624047 in web_client.md you still have Options and Arguments (if I'm not mistaken). Does anyone have objections to merging this after that is fixed? --- If your

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123702675 The yarn tests build fine on my machine with your branch. Seems to be a general issue within the YARN tests. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123703823 Ok. So this PR can be merged, I guess. I will open a JIRA for the failing test. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123707491 Yes, please open a JIRA. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/904 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-17 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-18243 Any news on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-13 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-120958268 Just updated this PR: - renamed Options to Flink Options and Arguments to Program Arguments in WebUI - removed redundant code and integrated CliFrontend ---

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-12 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-120707231 +1 for renaming. I confused the difference between the options and arguments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-120702048 Are there any other possible options for the options field except for the parallelism? I think users might be confused how the options and arguments differ. --- If

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-120706769 Right now, there is only `-c` that must be used if no Manifest (program-class or Main-Class argument) is given. We can also clarify via tooltips or help-popup, that

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-120731537 Yes, would be great if we could reuse CLI code., agreed... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-120731470 Btw: CliFontend support the follows options: -c / --class , -m / --jobmanager , -p / -- paralleslism To have the same options, we might want to extend CliFontend

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-10 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/flink/pull/904 [FLINK-2218] Web client cannot distinguesh between Flink options and program arguments added new input fields 'options' to WebClient adapted WebClient-to-JobManager job submission logic