[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/859 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-07-13 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/859#issuecomment-120942293 Looks good. Merging this with a modification of the tests that they permit the runtime exception in some cases. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-07-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/859#issuecomment-119987554 1/4 of the physical memory seems sensible and indeed returns almost the same memory size as the maximum memory setting on my machine. I've adapted the pull request. --- If

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-07-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/859#issuecomment-119883278 Typically, programs can allocate as much memory as they like. We only take a fraction of the free physical memory for the manged memory. We could also take only half of the

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-07-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/859#issuecomment-119891011 Okay, from skimming over some Oracle docs, it seems the default max heap is 1/4 of the physical memory. Let's use that. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-07-08 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/859#issuecomment-119586674 Is this value actually accurate? It assumes that the JVM can grow to occupy the entire available main memory. Is that the case? --- If your project is set up

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-06-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/859#discussion_r33036711 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java --- @@ -137,7 +137,13 @@ public static long

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-06-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/859#discussion_r33036608 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java --- @@ -137,7 +137,13 @@ public static long

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-06-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/859#discussion_r33037235 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java --- @@ -137,7 +137,13 @@ public static long

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-06-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/859#discussion_r33019549 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java --- @@ -137,7 +137,13 @@ public static long

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-06-22 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/859#discussion_r32957111 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java --- @@ -137,7 +137,13 @@ public static long

[GitHub] flink pull request: [FLINK-2235] fix calculation of free memory fo...

2015-06-22 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/859 [FLINK-2235] fix calculation of free memory for local execution The Java runtime may return Long.MAX_VALUE for a call to the maxMemory() method of the Runtime class. In these cases, we simply use the