Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-135145689
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-134584442
I addressed @hsaputra's comments rebased to the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1039
[FLINK-2386] Add new KafkaConsumer, based on Kafka's Simple Consumer API
This pull request is based on https://github.com/apache/flink/pull/1028.
I'm creating another pull request because I
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-133494751
Okay, will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-133483983
Concerning the `FlinkKafkaConsumer081` and `FlinkKafkaConsumer082` - lets
keep them exactly to fix bugs underneath the hood.
I would actually move all this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-133470243
This needs to go into 0.9.1, so the diamond operators are going to be a
problem
There is no difference, currently, between the 0.8.2 and the 0.8.1 Kafka
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-133478852
Damn. You are right. I'll add the full type parameters again for the 0.9.1
backport (once this one is merged).
Should we even differentiate between them, or
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-133502218
Okay, I've relocated the source into the `flink-connector-kafka` module.
I added a convenience class `PersistentKafkaSource` in the exact same
package as in the old
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1039#discussion_r37681201
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1039#discussion_r37681294
--- Diff: flink-core/src/main/java/org/apache/flink/util/NetUtils.java ---
@@ -48,8 +48,9 @@ public static String getHostnameFromFQDN(String fqdn) {
11 matches
Mail list logo
