Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/980
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-129851909
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-129142526
Indeed, the setup should ensure that we get notifications on both sides of
the failure modulo failed checkpoints.
---
If your project is set up for it, you can reply to
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/980#discussion_r36584713
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamCheckpointNotifierITCase.java
---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to t
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-129042045
Simplified the testing topology and added a bit more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-128003870
Thanks, fair enough. I'll give it another try soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-128001829
In general I think it has a little more complexity than necessary coming
from the actual application implemented here. I would get rid of the
PrefixCounts and the specific
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-127952500
Sure, thanks for checking it out. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-127951550
Could you please wait until I get a chance to look at it? I will try to do
so later today :)
---
If your project is set up for it, you can reply to this email and have y
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-127944519
If no objections I will merge this in the evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/980#discussion_r36168137
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamCheckpointNotifierITCase.java
---
@@ -0,0 +1,429 @@
+/*
+ * Licensed to
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/980
[FLINK-2423] [streaming] ITCase for checkpoint notifications
See javadoc and Jira.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink
12 matches
Mail list logo
