[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-09 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1094#issuecomment-138923580 @chenliang613, thanks for the PR! I'll check it and merge it if everything is fine. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1094 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1094#issuecomment-138239089 Looks nice. Can you help me quickly? I would like to understand why the internal maven dependencies on the Java examples have problems when you use the

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-07 Thread chenliang613
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1094#issuecomment-138276703 Just as maillist the last message mentioned:

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1094#issuecomment-138294037 Strange, the dependency here should not be dependent on the individual program jars, but on the aggregate `flink-java-examples-0.10-SNAPSHOT.jar`, which is not

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-04 Thread chenliang613
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1087#issuecomment-137744893 The CI failure be reported from flink-yarn-tests .but in my local machine, i did many times checking with "mvn clean verify" in flink-yarn-tests, all are

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-04 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1094 [FLINK-2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-04 Thread chenliang613
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1094#issuecomment-137896176 The implementation method may not the best solution. Actually i tried a couple of solutions(for example:use finalName tag to replace classifier),but because there

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-04 Thread chenliang613
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [Flink 2493] Simplify names of example program...

2015-09-02 Thread chenliang613
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-02 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1087 [FLINK-2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples

[GitHub] flink pull request: [Flink 2493] Simplify names of example program...

2015-09-02 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1086 [Flink 2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples

[GitHub] flink pull request: [Flink 2493] Simplify names of example program...

2015-09-02 Thread chenliang613
GitHub user chenliang613 reopened a pull request: https://github.com/apache/flink/pull/1086 [Flink 2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting

[GitHub] flink pull request: [Flink 2493] Simplify names of example program...

2015-09-02 Thread chenliang613
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-02 Thread chenliang613
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1068 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-02 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-137095444 @chenliang613 Do you want to open another poll request with the fix? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-02 Thread chenliang613
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-137098642 @StephanEwen yes. may use another solution :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-08-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-135426825 Here is a reference to the CI result: https://s3.amazonaws.com/archive.travis-ci.org/jobs/77474252/log.txt You can always run `mvn clean verify` locally.

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-08-27 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-135420490 Thanks for picking up the issue. Could you make the changes for the `flink-streaming-examples` and the `flink-storm-compatibility-example` modules too, please? Also

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-08-27 Thread chenliang613
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-135580675 @mbalassi OK, i will make changes for flink-streaming-examples and flink-storm-compatibility-example modules too. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-08-27 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1068 [FLINK-2493] Simplify names of example program JARs The names of example JARs have a bit annoying, propose to replace examples/flinnk-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-08-27 Thread chenliang613
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-135591554 @StephanEwen sure! actually i did the verify operation at local machine. At my local machine's log msg showing: got reference jar(as below)from central