Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1044#issuecomment-135508810
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1044#issuecomment-134525712
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1044#discussion_r37765150
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/Keys.java ---
@@ -209,6 +209,9 @@ public ExpressionKeys(int[] groupingFields,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1044#discussion_r37766287
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/Keys.java ---
@@ -209,6 +209,9 @@ public ExpressionKeys(int[] groupingFields,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1044#discussion_r37766532
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/Keys.java ---
@@ -209,6 +209,9 @@ public ExpressionKeys(int[] groupingFields,
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1044#issuecomment-134129988
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1044
[FLINK-2556] Refactor/Fix pre-flight Key validation
Removed redundant key validation in DistinctOperator
Keys constructors now make sure the type of every key is an instance of
