Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/1239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-148775942
Manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1239#discussion_r42259842
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/AbstractHeapKvState.java
---
@@ -0,0
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/1239#discussion_r42098258
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/AbstractHeapKvState.java
---
@@ -0,0 +1,145
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146830200
I think when drawing the snapshot with `Checkpointed` you are already
inside a streaming `Function` or internal operator where one can easily access
that information
Github user senorcarbone commented on a diff in the pull request:
https://github.com/apache/flink/pull/1239#discussion_r41493576
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -322,73
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146465524
Overall looks very good. :+1:
I personally like having the non-partitioned operator states and I use them
in my programs, so I would prefer keeping them.
---
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146467354
So my argument is that the overhead of implementing the Checkpointed
interface for simple counters , offsets and the like is simply too much (and
annoying).
We
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146472181
on a related note, is anyone planning to complete snapshotting for cyclc
graphs for the 0.10 release? Unfortunately I do not have time to work on it
this week but
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146486097
Other important thing:
I think it would be very useful to add some extra context information to
the snapshot methods. Something that can be used to identify the
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146486750
I can live without the non-partitioned OperatorStates, but the context info
for the snapshots is very hard to work around I think.
---
If your project is set up for it,
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146511645
@ktzoumas that's understandable! We could consider it for the maintenance
release maybe if there is enough time
---
If your project is set up for it, you can
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146507802
Also in the StateBackend interface a close method would come in handy,
similarly to the initialize to close connections etc. in case of failures.
---
If your project is
Github user ktzoumas commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146490272
@senorcarbone I think the cyclic graphs feature will be hard to get into
0.10
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1239#discussion_r41509657
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
---
@@ -471,7
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1239#discussion_r41528403
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -322,73
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146594656
As for the context, I did not mean to add it to the Checkpointed interface
but to the state backend method calls.
Other simpler solution for now would be to
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1239
[FLINK-2808] Rework state abstraction and clean up task / operator internals
This pull request fixes many related/intermixed issues. It was hard to
split this into individual issues.
18 matches
Mail list logo
