[GitHub] flink pull request: [FLINK-2818] [runtime] Corrected javadocs of *...

2015-10-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2818] [runtime] Corrected javadocs of *...

2015-10-09 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1224#issuecomment-146885004 I'll merge this with addressing @StephanEwen's comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2818] [runtime] Corrected javadocs of *...

2015-10-06 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1224#issuecomment-145781279 Looks good, +1 to merge BTW: I think its not necessary to {@link} the return types - they are linked anyways in the JavaDoc. --- If your project is set up

[GitHub] flink pull request: [FLINK-2818] [runtime] Corrected javadocs of *...

2015-10-06 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1224#issuecomment-145811668 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2818] [runtime] Corrected javadocs of *...

2015-10-04 Thread ggevay
GitHub user ggevay opened a pull request: https://github.com/apache/flink/pull/1224 [FLINK-2818] [runtime] Corrected javadocs of *ReduceDriver classes - "The iterator is handed to the reduce() method of the ReduceFunction." In the cases of ReduceDriver and AllReduceDriver,