Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1939
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1939#issuecomment-215096897
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1939#issuecomment-215008042
Thank you @fhueske! +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1939#issuecomment-214922363
Thanks for the review @vasia. I addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61123187
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/TableSourceTable.scala
---
@@ -0,0 +1,32 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61121181
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchTableSourceScanRule.scala
---
@@ -0,0 +1,71 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61120275
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -0,0 +1,126 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61120172
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -0,0 +1,139 @@
+/*
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61103432
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -0,0 +1,126 @@
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61106195
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/TableSourceITCase.scala
---
@@ -0,0 +1,123 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61106226
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/TableSourceITCase.scala
---
@@ -0,0 +1,123 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61105940
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/TableSourceITCase.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61105889
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/TableSourceITCase.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61105638
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/TableSourceTable.scala
---
@@ -0,0 +1,32 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61104611
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchTableSourceScanRule.scala
---
@@ -0,0 +1,71 @@
+/*
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61101726
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -0,0 +1,139 @@
+/*
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61098440
--- Diff: docs/apis/batch/libs/table.md ---
@@ -67,6 +67,165 @@ The central concept of the Table API is a `Table` which
represents a table with
The
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1939#discussion_r61098044
--- Diff: docs/apis/batch/libs/table.md ---
@@ -67,6 +67,165 @@ The central concept of the Table API is a `Table` which
represents a table with
The
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1939
[FLINK-2828] [tableAPI] Add TableSource interfaces for external tables.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
19 matches
Mail list logo
