Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52599200
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -148,6 +150,18 @@ public void dispose() {
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52469417
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -0,0 +1,175 @@
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1605#issuecomment-182421429
I addressed the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52494909
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -0,0 +1,175 @@
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1605#issuecomment-182575751
Doe it always require a "WindowFunction"? Can one also use only a
FoldFunction?
---
If your project is set up for it, you can reply to this email and have your
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1605#issuecomment-182583799
You can also do just a "fold". The window function is for when you need the
meta information about the window because the fold function does not get that.
---
If your
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52444710
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -0,0 +1,175
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52444796
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -0,0 +1,175
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52445422
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52445522
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52445570
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52446045
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/GenericFoldingState.java
---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52388115
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -0,0 +1,175 @@
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1605#issuecomment-182125713
You are adding new `.apply()` variants to the API which are not documented
with the PR.
---
If your project is set up for it, you can reply to this email and have
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1605#issuecomment-182237986
I'll add doc and also fix some other stuff in the doc that wasn't updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1605
[FLINK-2991] Add Folding State and use in WindowOperator
This enables efficient incremental aggregation of fold window.
This also adds:
- WindowedStream.apply(initVal, foldFunction,
17 matches
Mail list logo
