Github user subhankarb closed the pull request at:
https://github.com/apache/flink/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user subhankarb commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-187546037
hi matthias,
i was on vacation for 1 week. I'll update the pr once i get some input
from robert about my design.
On 22-Feb-2016 7:21 PM, "Robert
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-187184409
Sorry, I'm currently very busy with the 1.0 release. I hope I'll find some
time to look into this PR again later this week.
---
If your project is set up for it, you
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-184216894
Any progress here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user subhankarb commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-181340467
@rmetzger sorry for late reply.
plz take a look at the gist
https://gist.github.com/subhankarb/6a503378063819eb47e9
user can choose which one they want to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180746275
How do you want to implement this? I'm asking because I don't see an
obvious way to expose this to the user.
---
If your project is set up for it, you can reply to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r52015801
--- Diff: docs/apis/streaming/connectors/redis.md ---
@@ -0,0 +1,70 @@
+---
+title: "Redis Connector"
+
+# Sub-level navigation
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r52016008
--- Diff: docs/apis/streaming/connectors/redis.md ---
@@ -0,0 +1,70 @@
+---
+title: "Redis Connector"
+
+# Sub-level navigation
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180362938
Just a minor comment about the documentation. Otherwise, looks good to me.
@rmetzger can you review this, too? (You are familiar with the connectors
in general -- I
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180378937
Actually, I worked a bit with redis recently ;) I'll take a look at the PR
now.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r52023113
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,160 @@
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180385898
Thanks a lot for working on this!
I like the pull request!
Just out of curiosity, did you test the throughput you can get with the
connector?
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r52023695
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java
---
@@ -0,0 +1,131
Github user subhankarb commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180679993
@rmetzger when i started i had only pubsub in my mind. today i thought
about added list, sorted set for sink+source and hash and set for sink only.
i'll update the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51700142
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699024
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699060
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51700184
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699767
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699856
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699225
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699774
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51717701
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,143 @@
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51717544
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,143 @@
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-179221148
Please *rebase* on current master instead of merging the current master
into your branch. See "Preparing and submitting your contribution" in
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699764
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107 @@
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-179257332
Please add documentation for the web page. For details, see here:
https://github.com/apache/flink/tree/master/docs
---
If your project is set up for it, you can reply to
GitHub user subhankarb opened a pull request:
https://github.com/apache/flink/pull/1580
[FLINK-3034][Streaming Connectors] Redis Sink Connector
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/subhankarb/flink FLINK-3034
28 matches
Mail list logo
