Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1392#issuecomment-159682996
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1392#issuecomment-159747567
Will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1392#issuecomment-159692006
Love it!
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jaoki commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45791866
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
Github user jaoki commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45792220
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45580248
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1392#discussion_r45580214
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1343,10 +1343,34 @@ public long count() throws Exception {
//
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1392#issuecomment-158877137
Thanks for improving this. The docs were not obvious, and your change makes
it much better.
I added two comments, otherwise this looks good to me.
---
If
GitHub user jaoki opened a pull request:
https://github.com/apache/flink/pull/1392
[FLINK-3059] Javadoc fix for DataSet.writeAsText()
Currently writeAsText() in javadoc states it simply generates a file,
but this is not always true and it depends on the environment
10 matches
Mail list logo
