Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1470
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-184239679
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-183271832
Thank you very much! Behaviour is as I would expect it.
Last minor comment: can you add a comment in the deprecated methods (both
Java and Scala) with a reference
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-183268932
Alright, I've reintroduced the old execution attempts and delay
configuration values and the API calls at the `ExecutionEnvironment`.
The behaviour is now
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-183272439
Sure, will do. Thanks for the review :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-181981959
If nobody objects, then I would like to merge this PR, since it will give
us more flexibility in the future with respect to restarting strategies.
---
If your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-179156104
I addressed Ufuk's comments and rebased on the latest master + PR #1577. If
we are ok with the changes, which are API breaking because they change how the
restart
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r51556295
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -237,53 +236,26 @@ public ExecutionConfig setParallelism(int
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r51556358
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java
---
@@ -0,0 +1,113 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r51557132
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r51557088
--- Diff: docs/apis/fault_tolerance.md ---
@@ -193,73 +193,169 @@ state updates) of Flink coupled with bundled sinks:
[Back to top](#top)
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-174450252
Whats the status of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-174463868
Haven't received a +1 for merging yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r50679685
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -237,53 +236,26 @@ public ExecutionConfig setParallelism(int
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r50681234
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java
---
@@ -0,0 +1,113 @@
+/*
+ *
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r50681471
--- Diff: docs/apis/fault_tolerance.md ---
@@ -193,73 +193,169 @@ state updates) of Flink coupled with bundled sinks:
[Back to top](#top)
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1470#discussion_r50682036
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-169675092
Thanks for the review @rmetzger.
I think this is not a problem, because the user cannot define restart
strategies. In order to set a `RestartStrategy`, the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-169668035
I like this change because the current restart behavior is not flexible
enough. Resolving this issue should be really easy with your change in:
19 matches
Mail list logo
