Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1613#issuecomment-182398407
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1613
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1613#issuecomment-182277343
Thanks for the review @StephanEwen.
The problem is that the test case for the problem is inherently unstable on
Travis, because it depends on timeouts. I
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1613#discussion_r52441996
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -107,7 +108,7 @@
private static final
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1613#discussion_r52438500
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -107,7 +108,7 @@
private static final
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1613#discussion_r52432150
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -107,7 +108,7 @@
private static final
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1613#discussion_r52368138
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -107,7 +108,7 @@
private static final
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1613#issuecomment-182046481
Looks good, with one inline comment.
Otherwise, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1613
[FLINK-3260] [runtime] Enforce terminal state of Executions
This commit fixes the problem that Executions could leave their terminal
state
FINISHED to transition to FAILED. Such a
