[GitHub] flink pull request: [FLINK-3335] [runtime] Fix DataSourceTask obje...

2016-02-22 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/1616 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3335] [runtime] Fix DataSourceTask obje...

2016-02-22 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1616#issuecomment-187240850 Considering this and other recent discussions I agree that introducing a high-level copy would be detrimental and that there are better solutions. I would still like

[GitHub] flink pull request: [FLINK-3335] [runtime] Fix DataSourceTask obje...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1616#issuecomment-182390682 I am very hesitant to introduce an "always copy" step in the data sources. Some data sources create Avro or Thrift types which are incredibly expensive to copy.

[GitHub] flink pull request: [FLINK-3335] [runtime] Fix DataSourceTask obje...

2016-02-09 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1616 [FLINK-3335] [runtime] Fix DataSourceTask object reuse when disabled When object reuse is disabled, `DataSourceTask` now copies objects received from the `InputFormat` to prevent the collection