Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/1794
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-208438856
merged in 2e63d1afb2358760109ba0c90011ef565eaae0ff
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-208381444
Thanks, Chesnay! Can you merge this to `master`? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r59208369
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
---
@@ -1066,26 +1069,23 @@ public Void answer(Invoca
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r59193164
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
---
@@ -1066,26 +1069,23 @@ public Void answer(Invocatio
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r59193042
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
---
@@ -1066,26 +1069,23 @@ public Void answer(Invocatio
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-206262455
Very nice!
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-205887495
reworked test to be more reliable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-205306447
How about adjusting the test such that it works the following way:
- it polls the number of checkpoint calls (from the atomic integer), say
every 100 ms
-
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-205303755
The code looks good, but the tests are bound to be unstable. Making the
assumption that sleeps actually sleep as long as they should is often violated
(seems especia
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-197462397
I had a feeling that this solution was too simple to be correct, and in
fact it is the case.
on the bright side, i have a pretty good idea on how to solve this pr
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-197338128
Is it in line with the documentation that this only applies if there are
queued requests, i.e. is it OK that a checkpoint might be triggered right after
a checkpoint has com
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-197341137
i mean, the ScheduledTrigger was supposed to make sure that a min Interval
is kept between the last completed Checkpoint and the next one to trigger.
---
If your project
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-197385184
I've revisited this PR:
* ScheduledTrigger remains unchanged
* StreamEecutionEnvironment remains unchanged
* if the minIntervalBetweenCheckpoints is > 0 a diffe
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r56330207
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -277,6 +277,29 @@ public StreamExe
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-197340895
you are correct @uce , looking back that's what the ScheduledTrigger was
supposed to do; which i reverted a bit too quickly.
---
If your project is set up for it, you ca
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-197832914
Third time's the charm:
* the time of the last triggered checkpoint is stored
* when a checkpoint is triggered we check whether the interval has passed,
if so we r
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r56155936
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -921,11 +921,20 @@ public ActorGateway
createActi
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-196801937
The changes from the PR should also be reflected in the documentation and
there are no tests for it.
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r56155661
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -277,6 +277,29 @@ public Stre
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-196800536
Good work @zentol :-) I had some inline comments. It could be good to add a
test case for the min pause interval.
---
If your project is set up for it, you can rep
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r56155005
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -277,6 +277,29 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r56154789
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -921,11 +921,20 @@ public ActorGateway
crea
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r56154469
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -921,11 +921,20 @@ public ActorGateway
crea
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1794
[FLINK-3492] Configurable interval between Checkpoints
This PR allows the user to set a minimum interval between checkpoints. This
interval is used if a checkpoint is triggered, while another one is
25 matches
Mail list logo
