[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1914 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1914#issuecomment-214678100 Test failures are unrelated. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-25 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1914#issuecomment-214299635 I've addressed the problem of the failing test cases by introducing a CLI option to specify the configuration directory. That way, we can also set a valid configura

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-25 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1914#issuecomment-214278457 They should work independently of #1904. I have to check why the tests fail. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-25 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1914#issuecomment-214263164 I'm asking since the scala shell tests fail both in travis and locally. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-25 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1914#issuecomment-214262824 Does this commit only work in combination with #1904? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-25 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1914#issuecomment-214246701 Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-25 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1914#issuecomment-214224340 Good catch! +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] flink pull request: [FLINK-3775] [shell] Load Flink configuration ...

2016-04-19 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/1914 [FLINK-3775] [shell] Load Flink configuration before forwarding it This commit makes sure that the GlobalConfiguration is loaded before the FlinkShell is started. - [X] General