Github user chobeat commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65356053
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,166 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65355487
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,166 @@
+/*
+ *
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1996
@chobeat Okay. Then we should force user to calculate dimensionality of
matrix by changing type of number parameters in constructor.
---
If your project is set up for it, you can reply to
Github user chobeat commented on the pull request:
https://github.com/apache/flink/pull/1996
@chiwanpark I think it should be better to leave to the user the
computation of the dimensionality. I tried different options and all of them
are sub-optimal. I would leave this feature for
Github user chobeat commented on the pull request:
https://github.com/apache/flink/pull/1996
@chiwanpark before merging I need to go over the numRows/numCols issue
again because I noticed they create problems in another project of mine. I
think that the `collect()` there is too risky
Github user chobeat commented on the pull request:
https://github.com/apache/flink/pull/1996
@chiwanpark Yeah I thought I could write the documentation as a third PR
but I would like to review the block matrix first because it may change in
structure. Anyway I will soon begin working
Github user chobeat commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65318407
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,179 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65311449
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,179 @@
+/*
+ *
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1996
Hi @chobeat, thanks for update PR. After addressing comments on source
code, I think the last thing to merge this is adding documentation for this.
But you can add the documentation after
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65309988
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,179 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65309186
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,179 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65309134
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,182 @@
+/*
+ *
12 matches
Mail list logo
