[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2056 Thanks for fixing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2056 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/2056 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/2056 Thanks for clarifying @StephanEwen! I'll merge this after Travis succeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2056 There is actually a problem with the way the Scala Tests are written: The code in the class that is outside the "it should" clauses is executed before the "before" function. That

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2056 It is a bit tricky to understand what happens when with these tests using stacked traits... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2056 The limit should be set to 4 by the test tools already. I think the issue may be that the Execution Environment was prior to Chiwan's change acquired before the context was properly set

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/2056 Thanks for guide @mxm. I'll set upper limit for the parallelism to 4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2056 I'm not sure whether the changes fix the problem. I think you were lucky with the build machine on Travis :) The issue on Travis is that the `ExecutionEnvironment` defaults to using the number of

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

GitHub user chiwanpark opened a pull request: https://github.com/apache/flink/pull/2056 [FLINK-3994] [ml, tests] Fix flaky KNN integration tests This PR is related to flaky KNN integration tests. The problem is caused by sharing `ExecutionEnvironment` between test cases. I'm not