Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/492
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-84008396
Manually merged in 633b0d6a9b25fd324f1aa007bbce246be304c099
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83669510
After correcting the commit message ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83669339
Good, then I'll try and merge this today...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83655940
+1 SHIP IT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83649446
As in your comment in this PR, I think you make a small spelling mistake
"Renames the package org.apache.flink.compiler to org.apache.fink.optimizer",
which should be
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83469816
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83463402
Any objections against merging this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-82587340
Agree, let's do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-82579347
I think it is fine if we mention in the release notes that the name has
changed.
All the quickstart pom users won't be affected.
---
If your project is set up for it
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-82577264
We can do that, I am okay with this. So far, all renaming was strictly
internal.
The renaming of the maven project may affect some people who have added it
as
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-82576423
Why aren't we renaming the `flink-compiler` module into `flink-optimizer`?
Its an internal module only, so users won't see what we reorganized our
code internally.
-
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/492
[FLINK-441] Rename Pact* and Nephele* classes in the optimizer
Renames the package `org.apache.flink.compiler` to
`org.apache.fink.optimizer`
Renames `PactCompiler` to `Optimizer`
Renames
13 matches
Mail list logo
