[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/710#issuecomment-114154438 Helo @sachingoel0101, I've started reviewing this PR. It would help a lot if you check out these initial comments I made and try to fix similar issues throughout the

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32941921 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/DecisionTree.scala --- @@ -0,0 +1,490 @@ +/* + * Licensed to the

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32942116 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/DecisionTree.scala --- @@ -0,0 +1,490 @@ +/* + * Licensed to the

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32942958 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/tree/Tree.scala --- @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32943140 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/tree/Tree.scala --- @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32944309 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/DecisionTree.scala --- @@ -0,0 +1,490 @@ +/* + * Licensed to the

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32941719 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/DecisionTree.scala --- @@ -0,0 +1,490 @@ +/* + * Licensed to the

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32944368 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/DecisionTree.scala --- @@ -0,0 +1,490 @@ +/* + * Licensed to the

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32944538 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/DecisionTree.scala --- @@ -0,0 +1,490 @@ +/* + * Licensed to the

[GitHub] flink pull request: [Flink-1727]Decision tree

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/710#discussion_r32944486 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/DecisionTree.scala --- @@ -0,0 +1,490 @@ +/* + * Licensed to the