Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-216896832
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-216789910
Thanks for the update @gna-phetsarath. Good to merge, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user gna-phetsarath commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r61957444
--- Diff:
flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/AvroRecordInputFormatTest.java
---
@@ -289,6 +290,119 @@
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-216390708
Thanks for the PR @gna-phetsarath! I had one suggestion and one comment
about passing null in a objectReuse test.
Thanks, Fabian
---
If your project is set up for
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r61819570
--- Diff:
flink-batch-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroInputFormat.java
---
@@ -119,12 +138,14 @@ public E nextRecord(E
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r61819193
--- Diff:
flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/AvroRecordInputFormatTest.java
---
@@ -289,6 +290,119 @@ public void
Github user gna-phetsarath commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-215887300
Many contributions to Flink is a great problem to heave. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gna-phetsarath commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-215716418
@greghogan - What are next steps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-215717429
Sorry for the delay. The Flink community is receiving many contributions,
that causes sometimes long review times.
I think we can merge the change once @greghogan
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r61437731
--- Diff:
flink-batch-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroInputFormat.java
---
@@ -119,12 +138,14 @@ public E nextRecord(E
Github user gna-phetsarath commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r61269058
--- Diff:
flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/AvroRecordInputFormatTest.java
---
@@ -289,6 +290,119 @@
Github user gna-phetsarath commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-215092007
ReflectDatumReader does not work with GenericRecord because it is an
interface, so you need to use GenericDataReader.
---
If your project is set up for it, you
Github user gna-phetsarath commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r61261060
--- Diff:
flink-batch-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroInputFormat.java
---
@@ -119,12 +144,18 @@ public E
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-214463228
One more thought, since I've had this problem before. Since your pull
request started with multiple commits the title chosen by GitHub is based on
your branch name
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-214461886
Thanks for your contribution @gna-phetsarath.
I see there was a question in FLINK-3691 as to whether Flink already
serializes GenericRecords. It looks to me
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r60952095
--- Diff:
flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/AvroRecordInputFormatTest.java
---
@@ -289,6 +290,119 @@ public
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r60950868
--- Diff:
flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/io/avro/AvroRecordInputFormatTest.java
---
@@ -289,6 +290,119 @@ public
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r60949545
--- Diff:
flink-batch-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroInputFormat.java
---
@@ -119,12 +144,18 @@ public E
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r60948974
--- Diff:
flink-batch-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroInputFormat.java
---
@@ -51,11 +62,13 @@
private
GitHub user gna-phetsarath opened a pull request:
https://github.com/apache/flink/pull/1920
Flink 3691 extend avroinputformat to support generic records
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
21 matches
Mail list logo
