Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/2007
i believe what Stephan meant was the following:
* keep the abstract parseField method in FieldParser
* add a new method to FieldParser called resetErrorStateAndParse, which
calls
Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/2007
How should I proceed here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/2007#issuecomment-221880071
I don't understand :(
Assuming that `reset` could be renamed as `resetErrorStateAndParse`, the
other 2 suggestions cannot be applied to my current
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2007#issuecomment-221876052
I think I meant it a bit differently than I guess you understood it.
It is basically the exact same implementation you have now, only with
different method
Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/2007#issuecomment-221862570
Hi Stephan, thanks for reviewing this PR.
These are my reasons to not apply your suggestions to my PR, and I'd like
to hear your opinion (anyone interested by
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2007#issuecomment-221858427
Thanks for addressing this bug!
How about slightly changing the names of the methods:
- The method that resets the error state and parses would be
GitHub user fpompermaier opened a pull request:
https://github.com/apache/flink/pull/2007
[Flink-3908] Fixed Parser's error state reset
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
