Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922360
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922432
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922815
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922199
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29927671
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29927830
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-100173917
Looks good. Two minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-100175431
Want me to do the rebase and squashing or will you take care of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-100175119
Looks good :-) Thanks for you great work @thvasilo. Will merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/613
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29836966
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationType.scala
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29837206
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationType.scala
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29837444
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Solver.scala
---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29836296
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29837353
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationType.scala
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29836811
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationType.scala
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-99798430
I had only some minor comments. Ping me once you have addressed them. And I
noticed that there are no unit tests for the `PredictionFunction`. Maybe you
can add one.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29837033
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationType.scala
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29856369
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,231 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29857205
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29859794
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29862806
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29856893
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PredictionFunction.scala
---
@@ -0,0 +1,38 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29856919
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29857231
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29857402
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PredictionFunction.scala
---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-99892555
Some more comments ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29858325
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29857278
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29857658
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-99064842
BTW some of the builds are still failing due to excessive logging. Any
ideas for a fix?
---
If your project is set up for it, you can reply to this email and have your
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29582076
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/LossFunction.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29582355
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/optimization/RegularizationITSuite.scala
---
@@ -0,0 +1,56 @@
+/*
+ *
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29597434
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/LossFunction.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29323051
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29330897
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29329016
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29329048
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29322598
--- Diff: docs/libs/ml/optimization.md ---
@@ -0,0 +1,218 @@
+---
+mathjax: include
+title: ML - Optimization
+displayTitle: a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29322782
--- Diff: docs/libs/ml/optimization.md ---
@@ -0,0 +1,218 @@
+---
+mathjax: include
+title: ML - Optimization
+displayTitle: a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29323162
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29323147
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29348180
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/LossFunction.scala
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29348536
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationType.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29347123
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29347156
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29044212
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/WeightVector.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29044450
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/optimization/GradientDescentITSuite.scala
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29044413
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/optimization/GradientDescentITSuite.scala
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-95917745
Some Travis builds are failing because of the 4MB log limit; one of tests
is running 2000 iterations creating a lot of log output.
Ideas on how to fix?
There is
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29044309
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationType.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to
GitHub user thvasilo opened a pull request:
https://github.com/apache/flink/pull/613
[WIP] - [FLINK-1807/1889] - Optimization frame work and initial SGD
implementation
This is a WIP PR for the optimization framework of the Flink ML library.
The design is a mix between how
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r28763749
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/WeightVector.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r28765413
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/WeightVector.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r28764408
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/BLAS.scala ---
@@ -0,0 +1,556 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r28763991
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/BLAS.scala ---
@@ -0,0 +1,556 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r28763909
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/WeightVector.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r28764099
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/BLAS.scala ---
@@ -0,0 +1,556 @@
+/*
+ * Licensed to the Apache Software
58 matches
Mail list logo
