Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1025
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1025#issuecomment-132153447
Hey @Rucongzhang,
As this is your first contribution to Flink and the PR was issued before a
relevant notice on the developer mailing list that advises against
Github user Rucongzhang commented on the pull request:
https://github.com/apache/flink/pull/1025#issuecomment-131697201
@mbalassi , OK, I will modify it and name it splitsList.Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1025#issuecomment-131616685
I think this is a small enough and straightforward function that having the
same name for the return variable does not hurt that much. The name you have
suggested is re
GitHub user Rucongzhang opened a pull request:
https://github.com/apache/flink/pull/1025
[flink-2532]fix the function name and the variable name are the same
In class StreamWindow, in function split, there is a list variable also
called split. Two split are confusing , and the reada
