[GitHub] flink pull request: [github] change tab size to 4 spaces

2015-11-25 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159652327 @rmetzger I was also wondering why and turns out we do ignore dot files. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [github] change tab size to 4 spaces

2015-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [github] change tab size to 4 spaces

2015-11-25 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159637645 Yes +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [github] change tab size to 4 spaces

2015-11-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159637898 +1 I wonder why the rat plugin accepts the file without apache license header. Are we ignoring dot files? --- If your project is set up for it, you can reply

[GitHub] flink pull request: [github] change tab size to 4 spaces

2015-11-25 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1404 [github] change tab size to 4 spaces The default tab size on GitHub is 8 spaces. This change decreases the tab size to 4. I think this will make reviewing of code on GitHub easier. Left: