Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31138771
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
---
@@ -71,6 +71,11 @@ protected void onConsumedSubpar
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31138954
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
@@ -130,16 +131,12 @@ public void release() thr
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31137592
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
---
@@ -137,9 +211,46 @@ void onConsumedPartition(
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31136509
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -264,21 +266,21 @@ public void attachJobGraph(List
topol
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31136136
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
---
@@ -119,10 +153,50 @@ public void shutdown() {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31134168
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
---
@@ -119,10 +153,50 @@ public void shutdown() {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31131305
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
---
@@ -137,9 +211,46 @@ void onConsumedPartition(
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31131135
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -334,6 +335,14 @@ extends Actor with ActorLogMessages with
A
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31130488
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
---
@@ -40,9 +44,18 @@
private stati
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r31130185
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
---
@@ -40,9 +44,18 @@
private stati
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/640#issuecomment-97825782
Thank you for your valuable comments @tillrohrmann. I haven't worked with
Akka's future compositions but it seems a sophisticated way to parallelize and
combine the actor repl
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29435008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Softw
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29434283
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed to the Apache Softw
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/640#issuecomment-97818576
The backtracking looks good @mxm.
I have some remarks concerning the way the locking of the partition on the
TMs works. At the moment this happens sequentiall
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29433574
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apa
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29432849
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Softw
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29432635
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed to the Apa
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29432295
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apa
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29431402
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Softw
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29431413
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -475,11 +479,21 @@ class JobManager(val flinkConfiguration:
Co
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29431391
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Softw
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29427789
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -475,11 +479,21 @@ class JobManager(val flinkConfigura
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29426706
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apa
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29426482
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apa
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/640
[scheduling] implement backtracking of intermediate results
For batch programs, we currently schedule all tasks which are sources
and let them kick off the execution of the connected tasks. This
25 matches
Mail list logo
