Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-142857639
Can you add tests for the methods? I think there is already a class with
tests for all methods.
---
If your project is set up for it, you can reply to this email and
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-142948084
@rmetzger, sure, somehow I missed those tests. Now fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-143020279
Great, thank you.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-142482756
Looks good to merge. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1168
[utils] Missing getters for ParameterTool
When using the `ParameterTool` I have found the `Boolean` getter missing,
so added the missing functions.
You can merge this pull request into a Git
