Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-196237580
Thanks a lot @zentol and @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-196237048
You don't need to rebase. Chesnay did that already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-196234034
Thanks a lot! I will rebase in a bit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-196233679
Thank you. The changes in b75fd3f look good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-196229171
will merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-191812912
Thanks for your contribution @kl0u. Changes for the task cancellation
interval look good.
Maybe it would be good to add a test case which makes sure that
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-187144324
Just rebased. Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-185637228
Please review.
IMPORTANT NOTE: This PR is rebased on top of #1583 . Please review that
first.
---
If your project is set up for it, you can reply to this email and
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1662
FLINK-2523: Makes the task cancellation interval configurable.
This PR is rebased on top of https://github.com/apache/flink/pull/1583 .
Please review that first.
You can merge this pull request into
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1612#issuecomment-184236866
Hello! Just rebased to the new master. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1612#issuecomment-182413649
Thanks a lot for the comments @rmetzger and @tillrohrmann . I integrated
them.
Please review the new pull request.
This pull request is based upon the one about
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52386582
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150 @@
//
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385415
--- Diff: docs/apis/batch/index.md ---
@@ -2123,7 +2123,7 @@ Note that types registered with `registerKryoType()`
are not available to Flink'
-
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385934
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150 @@
//
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385223
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -27,13 +24,17 @@
import
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385698
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -141,9 +146,16 @@ public
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385188
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -75,16 +76,22 @@ public void
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52386295
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150 @@
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52356401
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150 @@
//
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388927
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150 @@
//
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388853
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150 @@
//
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388350
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -141,9 +146,16 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388830
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150 @@
//
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1612
FLINK-2523: Makes the task cancellation interval configurable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink
26 matches
Mail list logo
