Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137923702
+1
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1089
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tedyu commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137772269
Your reasoning w.r.t. current scope of try block was the same as mine.
I think it is good to make the scope as accurate as possible. Generally
speaking, we don't
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137857005
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137837300
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137761664
Thanks for the PR. The change looks good. It is good to merge.
The following comment is optional to address: I understand that you didn't
add the last two
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1089
FLINK-2605 Unclosed RandomAccessFile may leak resource in StaticFileSâ¦
â¦erverHandler
You can merge this pull request into a Git repository by running:
$ git pull
