Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-205278645
Will merge this if there are no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199850351
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199715433
Good to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199711790
Good to merge in my opinion. If there are no other comments on the
template, I will merge the PR in a few days.
Thanks again @mliesenberg!
---
If your project is
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199710458
thanks. removed the regression, squashed and rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199707109
I like the template! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r56953234
--- Diff: CONTRIBUTING.md ---
@@ -7,5 +7,6 @@ To make the process smooth for the project *committers*
(those who review and ac
## Contribution
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r55687974
--- Diff: CONTRIBUTING.md ---
@@ -8,4 +8,4 @@ To make the process smooth for the project *committers*
(those who review and ac
Please check out the
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-194879749
Yes, the test failures are unrelated. Looks good. Could you incorporate the
last comments?
---
If your project is set up for it, you can reply to this email and have your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r55688207
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink. Before you open your pull
request, please take the
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-194873275
build failed because all jobs failed the
`ClassLoaderITCase.testJobsWithCustomClassLoader` test.
I guess this is unrelated.
---
If your project is set up for
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-191670860
Thanks for the feedback, I will update the PR tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-191639327
Should be a link from CONTRIBUTING page to this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54551538
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please
kindly take into
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54551542
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please
kindly take into
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54353877
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please
kindly take into
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54353870
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please
kindly take into
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54353866
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please
kindly take into
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1729
FLINK-3529 Add template for pull requests
- added markdown as discussed on the mailing list
- added template to list of excluded files of rat plugin
You can merge this pull request into a
20 matches
Mail list logo
