Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/210#issuecomment-76385275
I moved the `writeInto(ByteBuf buf)` method to the subclasses of
`AbstractID` used by `NettyMessage`. This is the only context where the method
is being used and the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r25429114
--- Diff: flink-core/pom.xml ---
@@ -58,6 +58,12 @@ under the License.
version0.5.1/version
/dependency
+
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r25426681
--- Diff: flink-core/pom.xml ---
@@ -58,6 +58,12 @@ under the License.
version0.5.1/version
/dependency
+
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r25426145
--- Diff: flink-core/pom.xml ---
@@ -58,6 +58,12 @@ under the License.
version0.5.1/version
/dependency
+
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/210#issuecomment-76151146
I squashed the commits and rebased to the current master. Any objections
against merging this?
---
If your project is set up for it, you can reply to this email and have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/210#issuecomment-71726730
@zentol You are right, for the time being, that this results in parts in
repeated execution. While not totally unavoidable in all cases, the code going
in soon about
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/210#issuecomment-70718732
I've implemented count and collect in the Scala API. There is still a
problem with the `ListAccumulator` for non-primitive Objects (e.g. not Integer
or Long) probably due to
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r23080920
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ListAccumulator.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r23081185
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/AbstractIDTest.java ---
@@ -23,8 +23,8 @@
import static org.junit.Assert.fail;
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/210#issuecomment-70258735
With the scheduler and intermediate data set enhancements coming up for 0.9
soon, this is now quite feasible to use. I suggest to merge it once the inline
comments
11 matches
Mail list logo
