[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2084#discussion_r67146087 --- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java --- @@ -234,6 +234,22 @@ public static void checkElementIndex(int index, int

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2084#discussion_r67120005 --- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java --- @@ -234,6 +234,22 @@ public static void checkElementIndex(int index, int

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2084#discussion_r67119824 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnCluster.java --- @@ -250,7 +250,7 @@ public void disconnect() { */

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2084#discussion_r67119787 --- Diff: tools/maven/checkstyle.xml --- @@ -60,6 +60,17 @@ under the License. +

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2084#discussion_r67119642 --- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java --- @@ -234,6 +234,22 @@ public static void checkElementIndex(int index, int

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2084#discussion_r67119231 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BloomFilter.java --- @@ -18,10 +18,10 @@ package

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2084#discussion_r67118763 --- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java --- @@ -234,6 +234,22 @@ public static void checkElementIndex(int index, int

[GitHub] flink pull request #2084: [FLINK-4032] Replace all usages Guava precondition...

2016-06-08 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2084 [FLINK-4032] Replace all usages Guava preconditions This PR replaces every usage of the Guava Preconditions in Flink with our own Preconditions class. In addition, - the guava