[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-09-16 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r79157764 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs a program.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-09-16 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r79157293 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs a program.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-09-16 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r79156877 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -241,8 +255,11 @@ private static Options

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-09-07 Thread chobeat
Github user chobeat commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r7389 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs a program.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71355731 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,21 +17,39 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354413 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java --- @@ -0,0 +1,39 @@ +package org.apache.flink.client; + +

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354777 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,21 +17,39 @@ # limitations under the License. --- End diff -- You change the mode

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354529 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -110,6 +110,8 @@ public void testRun() {

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354329 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java --- @@ -148,4 +148,5 @@ public boolean getDetachedMode() { public

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354132 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -451,4 +479,25 @@ public static InfoOptions

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354207 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -451,4 +479,25 @@ public static InfoOptions

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71353752 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -451,4 +479,25 @@ public static InfoOptions

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71332501 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs a program.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123467 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java --- @@ -0,0 +1,35 @@ +package org.apache.flink.client; + +

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123415 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java --- @@ -0,0 +1,35 @@ +package org.apache.flink.client; + +

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123376 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java --- @@ -0,0 +1,35 @@ +package org.apache.flink.client; + +

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123278 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -459,4 +476,14 @@ public static InfoOptions

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69101922 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69101854 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-29 Thread alkagin
Github user alkagin commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68937366 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68910391 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread alkagin
Github user alkagin commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68750010 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68746527 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread alkagin
Github user alkagin commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68743480 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread alkagin
Github user alkagin commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68743195 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742325 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread alkagin
Github user alkagin commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742339 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -100,15 +100,22 @@ public void testRun() {

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742191 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742138 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742023 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741918 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -100,15 +100,22 @@ public void testRun() { }

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741598 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741402 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread alkagin
Github user alkagin commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68568030 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread alkagin
Github user alkagin commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68567354 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs a program.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68551210 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -33,6 +47,22 @@ while [ -L "$target" ]; do iteration=$((iteration + 1)) done +

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68551023 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,6 +17,20 @@ # limitations under the License.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550807 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -98,6 +98,12 @@ public void testRun() {

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550677 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -76,6 +76,9 @@ static final Option

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550234 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550224 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550160 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs a program.

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-23 Thread alkagin
GitHub user alkagin opened a pull request: https://github.com/apache/flink/pull/2149 [FLINK-4084] Add configDir parameter to CliFrontend and flink shell script Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into