[GitHub] flink pull request #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis c...

2016-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis c...

2016-07-12 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2228#discussion_r70443267 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java ---

[GitHub] flink pull request #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis c...

2016-07-12 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2228#discussion_r70437664 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java

[GitHub] flink pull request #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis c...

2016-07-12 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2228#discussion_r70413349 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java ---

[GitHub] flink pull request #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis c...

2016-07-12 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/2228 [FLINK-4170][kinesis-connector] Simplify Kinesis connecter config keys to be less overly verbose Changes included with this PR: 1) Separate consumer & producer config keys into 2 classes: