Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2319
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r6877
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/composite.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r4877
--- Diff: docs/dev/table_api.md ---
@@ -1656,6 +1656,29 @@ temporalOverlaps(TIMEPOINT, TEMPORAL, TIMEPOINT,
TEMPORAL)
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88679280
--- Diff: docs/dev/table_api.md ---
@@ -1656,6 +1656,29 @@ temporalOverlaps(TIMEPOINT, TEMPORAL, TIMEPOINT,
TEMPORAL)
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88684517
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/composite.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88679626
--- Diff: docs/dev/table_api.md ---
@@ -1656,6 +1656,29 @@ temporalOverlaps(TIMEPOINT, TEMPORAL, TIMEPOINT,
TEMPORAL)
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88683102
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/composite.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88699109
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/RexNodeTranslator.scala
---
@@ -74,15 +75,52 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88682935
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ExpressionParser.scala
---
@@ -324,10 +335,19 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88682137
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkTypeFactory.scala
---
@@ -79,14 +83,27 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r88699648
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/composite.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r83556947
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkTypeFactory.scala
---
@@ -79,14 +83,27 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r83556835
--- Diff: docs/dev/table_api.md ---
@@ -1656,6 +1656,29 @@ temporalOverlaps(TIMEPOINT, TEMPORAL, TIMEPOINT,
TEMPORAL)
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r83492774
--- Diff: docs/dev/table_api.md ---
@@ -1656,6 +1656,29 @@ temporalOverlaps(TIMEPOINT, TEMPORAL, TIMEPOINT,
TEMPORAL)
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r83492573
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkTypeFactory.scala
---
@@ -79,14 +83,27 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r80500304
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r76068132
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r76036947
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r76024507
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75998992
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75900712
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/CompositeAccessTest.scala
---
@@ -0,0 +1,167 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75900345
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75899092
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75898467
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/CompositeAccessTest.scala
---
@@ -0,0 +1,167 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75479712
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75479361
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/SelectITCase.scala
---
@@ -146,4 +146,22 @@ class SelectITCase(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75479103
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/CompositeAccessTest.scala
---
@@ -0,0 +1,167 @@
+/*
+ *
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2319
[FLINK-4294] [table] Allow access of composite type fields
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
28 matches
Mail list logo