[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2017-03-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r107792137 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamTableExample.scala --- @@ -18,18 +18,18 @@

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2017-03-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r107804086 --- Diff: flink-examples/flink-examples-table/pom.xml --- @@ -0,0 +1,108 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80955533 --- Diff: flink-examples/flink-examples-table/pom.xml --- @@ -0,0 +1,24 @@ + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80955413 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala --- @@ -15,7 +15,7 @@ * See the

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80916077 --- Diff: flink-examples/flink-examples-table/pom.xml --- @@ -0,0 +1,24 @@ + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80910964 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala --- @@ -15,7 +15,7 @@ * See the

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-02 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/2460 [FLINK-4562] table examples make an divided module in flink-examples only move table examle code to a divided module in flink-examples. Table API module should't contain example code.