Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2560
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2560#discussion_r81270921
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
@@ -60,6 +60,7 @@ class FlinkPlannerImpl(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2560#discussion_r81163353
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
@@ -60,6 +60,7 @@ class FlinkPlannerImpl(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2560#discussion_r80927113
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala
---
@@ -228,19 +229,13 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2560#discussion_r80925547
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/BatchTableEnvironmentTest.scala
---
@@ -0,0 +1,46 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2560#discussion_r80919671
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala
---
@@ -228,19 +229,13 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2560#discussion_r80921875
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkRelBuilder.scala
---
@@ -38,7 +38,12 @@ class FlinkRelBuilder(
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2560
[FLINK-4068] [table] Move constant computations out of code-generated
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
