[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-07 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/2571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82157384 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -136,53 +127,34 @@ public

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82156547 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -416,15 +333,14 @@ private boolean

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82155691 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -205,46 +177,64 @@ public void

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82155453 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -118,9 +109,9 @@ public void

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82135948 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -118,9 +109,9 @@ public void

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82134943 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -245,22 +255,26 @@ public TaskExecutorGateway

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82134273 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -416,15 +333,14 @@ private boolean

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-10-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82132624 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -136,53 +127,34 @@ public

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-09-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2571 [FLINK-4348] Simplify logic of SlotManager This pull request is split up into two commits: 1. It removes some code from the `SlotManager` to make it simpler. - It makes use of