Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94960996
--- Diff: docs/dev/table_api.md ---
@@ -3744,6 +3745,50 @@ MIN(value)
+ Grouping functions
+ Description
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94960370
--- Diff: docs/dev/table_api.md ---
@@ -1442,7 +1443,7 @@ Although not every SQL feature is implemented yet,
some string combinations are
{%
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94961010
--- Diff: docs/dev/table_api.md ---
@@ -3744,6 +3745,50 @@ MIN(value)
+ Grouping functions
+ Description
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94964350
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateReduceGroupFunction.scala
---
@@ -87,6 +90,17 @@
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94965456
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -349,6 +354,19 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94966326
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/sql/GroupingSetsTest.java
---
@@ -0,0 +1,188 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94963463
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateReduceGroupFunction.scala
---
@@ -20,26 +20,29 @@
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94962145
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -50,30 +48,48 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94969330
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/sql/GroupingSetsTest.java
---
@@ -0,0 +1,188 @@
+/*
+ *
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94104843
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -98,7 +98,9 @@ object
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94104787
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateReduceGroupFunction.scala
---
@@ -40,6 +40,7 @@
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94104766
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateReduceCombineFunction.scala
---
@@ -41,12 +41,14 @@
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94104657
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -207,7 +210,9 @@ class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94104637
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -70,7 +71,9 @@ class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94104624
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala
---
@@ -104,7 +107,9 @@ class
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2976
[FLINK-5303] [table] Support for SQL GROUPING SETS clause.
Support for operators GROUPING SETS / ROLLUP / CUBE was added in this PR.
Also added some tests for check execution of SQL queries
17 matches
Mail list logo
