[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r10033 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala --- @@ -348,6 +349,47 @@ class ExecutionEnvironment(javaEnv:

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100337562 --- Diff: flink-tests/src/test/java/org/apache/flink/test/io/CsvReaderITCase.java --- @@ -122,6 +127,80 @@ public void testValueTypes() throws Exception {

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-08 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100247845 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java --- @@ -351,6 +356,32 @@ public CsvReader ignoreInvalidLines(){

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-08 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100247856 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java --- @@ -351,6 +356,32 @@ public CsvReader ignoreInvalidLines(){

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-08 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100247899 --- Diff: flink-tests/src/test/java/org/apache/flink/test/io/CsvReaderITCase.java --- @@ -122,6 +127,80 @@ public void testValueTypes() throws Exception {

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-08 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100247879 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala --- @@ -348,6 +349,47 @@ class ExecutionEnvironment(javaEnv:

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-08 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100247870 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala --- @@ -348,6 +349,47 @@ class ExecutionEnvironment(javaEnv:

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-08 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100247839 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -192,6 +193,28 @@ public void getFlatFields(String

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2016-12-15 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3012 [FLINK-2186] Add readCsvAsRow methods to CsvReader and scala ExecutionEnv Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into