[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-24 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102922045 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class SqlIT

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652877 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala --- @@ -52,9 +53,1

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652936 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/GlobalEventTimeRowWindowAssigner.java --- @@ -0,0 +1,113

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652926 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class SqlITCase

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652914 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class SqlITCase

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102650085 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0 +1,179

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102649307 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0 +1,179

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102634209 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class SqlIT

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102635310 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowRule.scala --- @@ -0,0 +1,87 @@

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631646 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0 +1

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102632122 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowRule.scala --- @@ -0,0 +1,87 @@

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631440 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0 +1

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102630342 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0 +1

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102632917 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/LogicalWindowRule.scala --- @@ -0,0 +1,73 @@ +/

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631105 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala --- @@ -52,9 +

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631831 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0 +1

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102634122 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class SqlIT

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102634927 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/GlobalEventTimeRowWindowAssigner.java --- @@ -0,0 +1,

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102633283 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -395,7 +395,8 @@ object Aggr

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
GitHub user hongyuhong opened a pull request: https://github.com/apache/flink/pull/3386 [FLINK-5658][table] support unbounded eventtime over window 1. Add LogicalOverWindow extends calcite Window with attribute isEventtime 2. Add LogicalWindowRule to convert calcite LogicalWindow

<    1   2