[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103183251 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java --- @@ -957,6 +964,42 @@ public void testPojoTypeWithPrivateField()

[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103203173 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java --- @@ -358,24 +358,27 @@ protected boolean

[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103203254 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java --- @@ -392,12 +395,17 @@ protected boolean

[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103197216 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java --- @@ -400,7 +400,7 @@ public void readMixedQuotedStringFields() {

[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103197368 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java --- @@ -311,7 +317,7 @@ public void

[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103200986 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/RowCsvInputFormat.java --- @@ -197,6 +197,14 @@ protected boolean parseRecord(Object[]